Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
|
Probably need a way to turn off the Mac + Enzyme combo which is known to be bad due to underpowered mac mini runners |
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
I definitely agree that we should start using similar setups in many places, but it could be nice if we could uniformize this and use a shared action/test setup, to keep this maintainable in the future?
Sure. I set this up here because the Enzyme tests are impacting other people. If someone wants to set up the shared workflow now, I don't see a problem, otherwise we can do this now and then remove it in another PR later once the shared one is set up? |
kshyatt
force-pushed
the
ksh/test_setup
branch
4 times, most recently
from
6674cec to
4be46d6
Compare
kshyatt
force-pushed
the
ksh/test_setup
branch
3 times, most recently
from
36d42d1 to
be2f0f2
Compare
|
Is this good to go if tests pass? |
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
Good for me!
(Re tests and rebasing this, lets first merge #217 once the tests pass of that one, then rebase this on top. I've cancelled the tests for now since we are oversubscribing our CI workers, and this can then rerun on top of that?)
|
Sounds good, sorry for rebasing so much stuff here and at TK 😅 |
|
Once this is in I can try #179 on top of it, it should allow the AD tests to actually finish... |
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
2 participants
Should give us some benefit from draft PRs and splitting the tests into smaller chunks